Use RasterPixmapData until we fix QEglGLPixmapData properly #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch includes both a change to use RasterPixmapData instead of our own QEglRasterPixmapData as well as a fix to make QEglGLPixmapData work to begin with. Due to the slow performance of the latter, we should refrain from using the Egl version until we can either make webkit not thrash pixmaps so much or improve the copying performance of egl pixmaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes both a change to use RasterPixmapData instead of
our own QEglRasterPixmapData as well as a fix to make QEglGLPixmapData
work to begin with. Due to the slow performance of the latter, we
should refrain from using the Egl version until we can either make webkit
not thrash pixmaps so much or improve the copying performance of egl
pixmaps.